Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some keyframes behaviors... #10

Merged
merged 13 commits into from Sep 9, 2014

Conversation

d-j-a-y
Copy link

@d-j-a-y d-j-a-y commented Sep 2, 2014

Fix 457 - disabled kf doens't work well on d&d (and around)
Fix 672 - kf loose activation status after dragging
Fix 458 - context menu in kf widget indicator
Fix 185 - Right click in keyframe list

Please, test it strongly has i did a change inside synfig-core !

…ons. Progress

In synfig-core, KeyframeList::insert_time, include deactivated kf while searching next.

Solve the reported bug.

But another one appear : previous deactivated kf now move during d&d operation !
…rations.

In synfig-studio, Widget_Keyframe_List::perform_move_kf, include deactivated kf while searching previous.

Solve the linked bug (see previous commit 24c87b8)
@d-j-a-y d-j-a-y changed the title Fix 457 Disabled keyframes doesn't work well with drag and drop operations Fix some keyframes behaviors... Sep 2, 2014
contextual menu is displayed with usual kf actions (add/remove/duplicate/properties)

tofix : current time is used in place of time line mouse position
- remove parent "keyframe" menu to only display keyframe actions
- prepare keyframe set description
- micro optimize and rationalize activation (set_sensitive) of actions by using variables
@d-j-a-y
Copy link
Author

d-j-a-y commented Sep 5, 2014

a433e58 (progress 9) select the kf on right click

@morevnaproject
Copy link
Owner

Hello! Just want to let you know that I didn't forgot about this pull request. Just need some time to test it completely. ^__^

@d-j-a-y
Copy link
Author

d-j-a-y commented Sep 7, 2014

sorry, another little one ;-)

@morevnaproject morevnaproject merged commit bb5929e into morevnaproject:gtk3 Sep 9, 2014
@morevnaproject
Copy link
Owner

Finally merged. ^__^
Please consider that there are still some issues with synfig#457 - http://www.synfig.org/issues/thebuggenie/synfig/issues/457#comment_2310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants